Repository navigation
Build immutable snapshot packets and verified diff anchors - #206
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d4745ca087
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
The controller currently receives a caller-supplied packet and diff map. This adds an immutable Git collector that produces both from the captured merge-base-to-head comparison, verifies hunk coordinates/text against committed blobs, and preserves controller-observed omissions through review and recovery.
Related to #176, which stays open. Private polling/backoff, qualified object acquisition and installation-token attestation, runtime composition and packaging remain required. This change does not activate the retired controller or qualify live subscription use.
Acceptance Criteria
Definition of Done
Validation
Head 84d62c2, tree e86c3398ef483de3991253860f72bffdec7f6f44, based on main e469979. Targeted snapshot race tests pass. All 18 Python tests and diff check pass. Go 1.25.14 vet and full race suite pass, including reviewer 43.307s and all fixture packages. Actions remains disabled by owner; no CI pass is claimed. No UI changes.
Actual installed Git 2.53.0 creates synthetic SHA-1 and SHA-256 commits, including an independently advanced base with the same tree as head. Tests still capture the merge-base changes. Quoted/Unicode paths, renames, deletion, newline markers, binaries, symlinks and submodules exercise the real producer rather than a second handwritten spelling of its output.
Working-tree and environment canaries plus executable hooks/external/textconv drivers remain inert during capture. A local inert promisor helper first proves lazy fetching would run without the controls, then proves capture records the missing blob without invoking that helper. No network is used.
Adversarial cases reject forged source/counts/coordinates, hidden gap edits, missing EOF markers, unsafe/duplicate paths, incomplete inventories, missing/non-commit revisions, wrong merge bases, cancellation and mismatched admitted packets. Blob/patch/file caps preserve omissions or refuse the whole packet.
Review corrections force
--ignore-submodules=noneagainst candidate/repository ignore settings; search preserves omissions while continuing to later readable matches; overflowing source coverage combines reasons per allowed path while preserving global exhaustion; typed rendering/publication revalidates the complete admitted job hash. Captured packets reject the low-level map-taking APIs. Existing ordinary denial records remain unchanged below the cap.Three new behavior regressions fail against the exact reviewed source archive and pass after the fixes. Cross-job publication tests reject mismatched jobs before storage, while the valid typed route persists a review intent.
The SQLite integration admits the actual Git packet, runs four fake provider phases with empty model coverage, recovers completed work without another provider call, and renders the authoritative binary/link/submodule omissions. No real provider profiles, inference, App installation or deployment are used.
Risks and remaining work
The explicit Git executable/object repository and its configuration remain trusted release input. This collector does not establish fork provenance, installation scope or managed-reader OS confinement. Those remain separately qualified boundaries.
The evidence packet is capped at 64 KiB, with at most 128 changed paths and two MiB aggregate blob reads. Oversized complete inventories defer admission; per-file omissions remain visible. Recovery must reproduce the exact admitted packet, including omissions, or defer instead of substituting fresh input.
See snapshot evidence documentation for API composition and limits.